Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return 400 Bad Request when "Host" header is null #105

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tkellogg
Copy link

Fixes #102

@veebs
Copy link
Member

veebs commented Dec 14, 2014

Thanks Tim

I'll process it over the Christmas break.

Sorry, just been flat chat at work

Thanks again,
Vibul

On 12 December 2014 at 10:50, Tim Kellogg [email protected] wrote:

Fixes #102 #102

You can merge this Pull Request by running

git pull https://github.com/tkellogg/socko issue-102

Or view, comment on, or merge it at:

#105
Commit Summary

  • Return 400 Bad Request when "Host" header is null

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#105.

@malibuworkcrew
Copy link

@veebs This looks good to me. We have been seeing failures when hit with HTTP/1.0 which does not require host header. This leads to connections not getting responses, timing out, and holding onto threads which eventually can kill servers hosting socko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When establishing a WebSocket, handle empty Host header
3 participants